Quote PHP_BINARY and CRUNZ_BIN in closure shell commands#127
Merged
PabloKowalczyk merged 1 commit intoMar 9, 2026
Merged
Conversation
f069338 to
caa2a86
Compare
Member
|
Thanks @eyupcanakman, since it's a bug fix please target |
Contributor
Author
|
Rebased onto 3.9, thanks. |
Member
|
Thanks @eyupcanakman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, when PHP is installed under a path that contains spaces (e.g.
C:\Program Files\PHP\php.exe), closure-based tasks fail silently.serializeClosure()inEvent.phpconcatenatesPHP_BINARYandCRUNZ_BINdirectly into the shell command string without quoting, so the OS splits the
path at the first space and tries to execute a truncated binary name.
Both values are now wrapped with
escapeshellarg(), which adds the appropriatequoting on every platform. The existing
serializeClosuretest is updated toexpect the quoted form.