Avoid calls to (*os.File).Fd() when calling ioctl#214
Closed
WeidiDeng wants to merge 13 commits into
Closed
Conversation
Co-authored-by: WeidiDeng <[email protected]>
….Pointer Co-authored-by: WeidiDeng <[email protected]>
Co-authored-by: WeidiDeng <[email protected]>
…r at syscall.Syscall site Co-authored-by: WeidiDeng <[email protected]>
… at syscall call site; remove ptrToUintptr helper Co-authored-by: WeidiDeng <[email protected]>
…tr).UnsafePointer()) inline at syscall call site Co-authored-by: WeidiDeng <[email protected]>
refactor: ioctl ptr parameter from uintptr to any
Contributor
Author
|
Superseded by #215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #167
(*os.File).SyscallConn()is used whenever possible, but it caused some operations to fail sometimes and had to be reverted.The problem is not race condition, but incorrect usage of
uintptr. In go, any pointer value should only be converted to uintptr when passed as arguments tosyscall.Syscall.According to test results, even the blocking version may rarely have this kind of problem.
Copilot was used to refactor the function signature and some manual editing to make sure it works.