Fix geojson creation with ring-shaped masks - #19
Open
leop-gne wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a mask has a ring-shaped object in it, such as a pen mark that forms a closed loop, the current geojson code will create a filled disk in the geojson. Additionally, the use of cv2 means the original mask is not recoverable from the resulting geojson. This is a proposed fix, though I've only implemented it in 01_WSI_inference_OPENSLIDE_QC and haven't updated the dependencies since I'm not certain which GeoPandas and shapely versions work with the current dependencies.
Here's an example of a ring-shaped object and the mask created by the current method and the proposed method.

The new method displays the polygon as being offset by half a pixel from the original mask, but this is solely a display effect from the convention of whether a vertex designates the bottom right corner of a pixel or the center of the pixel at display time. The original mask is recoverable with rasterio.features.rasterize: