[feat][observability] add is_system field to FilterField and FieldMeta#587
Open
cuichen01 wants to merge 1 commit into
Open
[feat][observability] add is_system field to FilterField and FieldMeta#587cuichen01 wants to merge 1 commit into
cuichen01 wants to merge 1 commit into
Conversation
Add optional bool is_system to ListSpans FilterField and GetTracesMetaInfo FieldMeta, allowing frontend to distinguish system fields and pass the is_system condition in trace query filters.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #587 +/- ##
==========================================
- Coverage 77.46% 77.44% -0.02%
==========================================
Files 679 679
Lines 80880 80891 +11
==========================================
- Hits 62652 62650 -2
- Misses 14493 14502 +9
- Partials 3735 3739 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional bool is_system to ListSpans FilterField and GetTracesMetaInfo FieldMeta, allowing frontend to distinguish system fields and pass the is_system condition in trace query filters.
What type of PR is this?
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes