Skip to content

[feat][observability] add is_system field to FilterField and FieldMeta#587

Open
cuichen01 wants to merge 1 commit into
mainfrom
feat/add-is-system-filter-field
Open

[feat][observability] add is_system field to FilterField and FieldMeta#587
cuichen01 wants to merge 1 commit into
mainfrom
feat/add-is-system-filter-field

Conversation

@cuichen01

Copy link
Copy Markdown
Collaborator

Add optional bool is_system to ListSpans FilterField and GetTracesMetaInfo FieldMeta, allowing frontend to distinguish system fields and pass the is_system condition in trace query filters.

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

Add optional bool is_system to ListSpans FilterField and GetTracesMetaInfo
FieldMeta, allowing frontend to distinguish system fields and pass the
is_system condition in trace query filters.
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ules/observability/application/convertor/filter.go 0.00% 5 Missing and 1 partial ⚠️
.../observability/application/convertor/trace/span.go 0.00% 2 Missing and 2 partials ⚠️
backend/modules/observability/application/trace.go 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   77.46%   77.44%   -0.02%     
==========================================
  Files         679      679              
  Lines       80880    80891      +11     
==========================================
- Hits        62652    62650       -2     
- Misses      14493    14502       +9     
- Partials     3735     3739       +4     
Flag Coverage Δ
unittests 77.44% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/observability/domain/component/config/config.go 50.00% <ø> (ø)
backend/modules/observability/application/trace.go 78.56% <0.00%> (-0.07%) ⬇️
.../observability/application/convertor/trace/span.go 85.42% <0.00%> (-1.41%) ⬇️
...ules/observability/application/convertor/filter.go 39.39% <0.00%> (-3.94%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f33b1...475d86d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant