iOS: fix comment composer auto-closing when keyboard opens - #47
Open
kubo6472 wants to merge 2 commits into
Open
Conversation
Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Jakub Doboš <[email protected]>
The comment input overlay was gated on GeometryReader width > height to detect landscape. When the keyboard appears, the available height shrinks enough that width exceeds height, so SwiftUI removed the TextField from the view hierarchy and focus (keyboard) was lost immediately. Track device orientation instead for landscape UI gating, and prevent the comments ScrollView from dismissing the keyboard on scroll. Co-authored-by: Jakub Doboš <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46
Problem
On iOS, tapping the comment composer (or Reply) would briefly show the keyboard, then immediately dismiss it — making it impossible to type a comment.
Root cause
The floating comment input was only shown when
GeometryReaderreported portrait (width <= height). When the keyboard opens, the available view height shrinks enough that width exceeds height, so SwiftUI treated the layout as landscape, removed theTextFieldfrom the hierarchy, and focus was lost.Fix
UIDevice.orientationDidChangeNotification) for landscape UI gating instead of geometry size.scrollDismissesKeyboard(.never)on the commentsScrollViewso incidental scrolling doesn't dismiss the keyboardTesting
Manual verification on iOS device/simulator: