fix(pi): strip trailing assistant messages, improve sanitize and error guards#32
Open
iceteaSA wants to merge 1 commit into
Open
fix(pi): strip trailing assistant messages, improve sanitize and error guards#32iceteaSA wants to merge 1 commit into
iceteaSA wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…r guards - Strip trailing assistant-role messages from converted requests to prevent Anthropic prefill 400 errors on some models - Add Unicode flag to surrogate regex for spec compliance - Simplify sanitizeToolId with cleaner length check - Improve error content guard to catch empty string case - Add comprehensive test coverage for all pi conversion logic
iceteaSA
force-pushed
the
fix/pi-improvements
branch
from
b659ab4 to
768e897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to pi/convert.ts beyond what was merged in #17:
/guflag) for spec-compliant surrogate pair replacementcontent === '') that upstream missesSummary by cubic
Fixes Anthropic prefill 400s by stripping trailing assistant messages in
packages/pirequests. Also tightens sanitization and error guards, and adds tests plus abun testscript./guin surrogate replacement for spec compliance.sanitizeToolIdwith deterministic allowed chars and a clean length check.tool_resulthasis_error=trueand empty content (including ''), inject "Error".testscript (bun test src/tests) and 21 tests covering conversion logic.Written for commit 768e897. Summary will update on new commits. Review in cubic