Skip to content

State that DESCRIPTION is unaltered#13

Merged
TroyHernandez merged 3 commits into
cornball-ai:mainfrom
eddelbuettel:feature/description_message
Jun 7, 2026
Merged

State that DESCRIPTION is unaltered#13
TroyHernandez merged 3 commits into
cornball-ai:mainfrom
eddelbuettel:feature/description_message

Conversation

@eddelbuettel

@eddelbuettel eddelbuettel commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

This PR is a bit of banter which I am not sure you are going to merge, or maybe merge after you make me add a verbose flag, but we now also say what we are not doing. Compare to the display in #12:

edd@paul:~/git/tl(master)$ trox.r 
Checking CRAN compliance...
Parsing R files...
Found 11 documentation block(s).
Generating Rd files...
Generated 1 Rd file(s).
Generating NAMESPACE...
Updated NAMESPACE.
Left DESCRIPTION alone as one should.
Warning messages:
1: CRAN: Exported functions without examples: debug, info, warn, error, critical, set_level, \
   get_level, set_name, get_name, set_format 
2: Undocumented parameters in set_format: utc, show_date, show_thread_id, precision 
edd@paul:~/git/tl(master)$ 

I leave it to your expert judgement to see if this 'improves' things, and remain curious about what your silicon coding partner makes of it.

PS Maybe also s/Left/Leaving/ ?

@eddelbuettel

Copy link
Copy Markdown
Collaborator Author

Ok, and in a more useful manner we now have a 'silent' argument suppressing all this. The issue in #12 is still there though even if cran_check=FALSE:

edd@paul:~/git/tl(master)$ trox.r 
Warning message:
Undocumented parameters in set_format: utc, show_date, show_thread_id, precision 
edd@paul:~/git/tl(master)$ 

@TroyHernandez TroyHernandez merged commit f67f0d9 into cornball-ai:main Jun 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants