initial version of cost metrics in cli#12
Open
Yash-gsx wants to merge 3 commits into
Open
Conversation
rsingh-alt
reviewed
Jul 21, 2026
| } | ||
|
|
||
| // queryTotalWatts returns the summed power.draw across all visible GPUs at one | ||
| // instant (total node GPU power, busy + idle). |
Contributor
There was a problem hiding this comment.
Here we are calculating power for the whole node, even if the gpu is idle. but in cost.go we are using CapEx for only the GPUs in use.
rsingh-alt
reviewed
Jul 21, 2026
| } | ||
|
|
||
| func (s *Sampler) sampleOnce() { | ||
| w, ok := queryTotalWatts() |
Contributor
There was a problem hiding this comment.
Power for all GPUs is being calculated.It should be calculated for the GPUs being used.
rsingh-alt
reviewed
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Update the rental tiers for other gpus too
rsingh-alt
reviewed
Jul 21, 2026
| Label string `json:"label"` | ||
| } | ||
|
|
||
| type MarketRate struct { |
Contributor
There was a problem hiding this comment.
hyperscaler_sku, neocloud_blended_hourly_usd, gpu_model, and electricity_source can be removed from here as they are not being used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.