fix(shopping-list): error on bad explicit --pantry, drop planning docs#343
Merged
dubadub merged 1 commit intoMay 15, 2026
Merged
Conversation
When --pantry is passed explicitly, surface read failures as errors instead of silently warning and producing an unfiltered list. Auto- discovered pantry paths still fall through silently, since absence is expected. Also remove the docs/superpowers/ planning artifacts that were inadvertently committed with the feature.
6 tasks
dubadub
added a commit
that referenced
this pull request
May 15, 2026
* docs: add design for shopping-list pantry flags Adds spec for --pantry and --ignore-pantry flags on the shopping-list command, mirroring the existing --aisle handling. * docs: add implementation plan for shopping-list pantry flags * feat(shopping-list): add --pantry and --ignore-pantry flags * refactor(shopping-list): drop unnecessary clone on args.pantry * fix(shopping-list): error on unreadable explicit --pantry path (#343) When --pantry is passed explicitly, surface read failures as errors instead of silently warning and producing an unfiltered list. Auto- discovered pantry paths still fall through silently, since absence is expected. Also remove the docs/superpowers/ planning artifacts that were inadvertently committed with the feature. Co-authored-by: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review items on #340.
Summary
docs/superpowers/planning artifacts that were inadvertently committed with the feature (flagged by all three reviewers).--pantry <path>cannot be read, instead of silently warning and producing an unfiltered list. Auto-discovered pantry paths still fall through silently since absence is expected.--ignore-pantrystill wins and performs no file I/O.Test plan
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo test--pantry /does/not/exist.confnow exits withFailed to read pantry file '/does/not/exist.conf': No such file or directory--ignore-pantry --pantry /does/not/exist.confstill succeeds (no read attempt) and matches the unfiltered listGenerated by Claude Code