feat(drive-integration): wire up CI deploy scripts for lerna []#10986
Open
Mitch Goudy (mgoudy91) wants to merge 2 commits into
Open
feat(drive-integration): wire up CI deploy scripts for lerna []#10986Mitch Goudy (mgoudy91) wants to merge 2 commits into
Mitch Goudy (mgoudy91) wants to merge 2 commits into
Conversation
Adds `deploy` and `deploy:test` scripts that lerna picks up on master merge — uploading the bundle via contentful-app-scripts and syncing to S3/CloudFront using the same env var conventions as other apps in the monorepo. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Mitch Goudy (mgoudy91)
changed the title
- Move test-only types (vitest/globals, @testing-library/jest-dom) and test/** include to tsconfig.test.json so they don't break the prod build - Exclude test/** from the main tsconfig.json - Add --ci flag to upload script to prevent interactive bundle comment prompt Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Joaquin (joaquincasal)
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployanddeploy:testscripts so lerna picks up the drive-integration app in the standard CI pipeline on master mergedeployuploads to prod app definition3EaGZUMKRKVZUyrcoNJ4o4viacontentful-app-scriptsusing vault-injected${DEFINITIONS_ORG_ID}/${CONTENTFUL_CMA_TOKEN}, then syncs to${STATIC_S3_BASE}/google-docsand invalidates the prod CloudFront distributiondeploy:testdoes the same for the staging definition (4i0mp5lQtgNsHYVrD5jIkj) using${TEST_ORG_ID}/${TEST_CMA_TOKEN}and the staging S3 pathnpm run buildbefore calling deploy, matching the pattern used by all other appsTest plan
lerna run deploy --since=HEAD^on master includes drive-integrationlerna run deploy:test --since=HEAD^on staging includes drive-integration🤖 Generated with Claude Code