HMS-10986: fix maven counts#40
Merged
TenSt merged 1 commit intoJul 9, 2026
Merged
Conversation
c2a720c to
ff28423
Compare
ochosi
reviewed
Jul 9, 2026
ff28423 to
d970cbb
Compare
ochosi
previously approved these changes
Jul 9, 2026
ochosi
left a comment
There was a problem hiding this comment.
I've reviewed the two parts that seem to matter most in this PR:
- the adjusted SQL statement
- the regular expression
Both make sense to me and should move us over to counting based on .jar files.
I will admit I did not review the tests.
d970cbb to
b8b7eb9
Compare
ochosi
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
package_countfrom.jarfiles instead of.pombuild_countto count distinct full versions, not jar filesversion_countto count distinct base versions (strips.rhlw-XXXX).Finalversion counting