Skip to content

HMS-10986: fix maven counts#40

Merged
TenSt merged 1 commit into
content-services:mainfrom
TenSt:stepan/HMS-10986-fix-maven-package-counts
Jul 9, 2026
Merged

HMS-10986: fix maven counts#40
TenSt merged 1 commit into
content-services:mainfrom
TenSt:stepan/HMS-10986-fix-maven-package-counts

Conversation

@TenSt

@TenSt TenSt commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This PR:

  • Fixes Maven package_count from .jar files instead of .pom
  • Fixes Maven build_count to count distinct full versions, not jar files
  • Fixes Maven version_count to count distinct base versions (strips .rhlw-XXXX)
  • Updates integration fixture to use release-qualified version paths
  • Adds unit tests for rhlw and standard .Final version counting

@TenSt TenSt requested a review from a team as a code owner July 9, 2026 09:35
@TenSt TenSt marked this pull request as draft July 9, 2026 09:38
@TenSt TenSt force-pushed the stepan/HMS-10986-fix-maven-package-counts branch 2 times, most recently from c2a720c to ff28423 Compare July 9, 2026 10:02
@TenSt TenSt marked this pull request as ready for review July 9, 2026 10:02
Comment thread docs/npm-plan.md Outdated
@TenSt TenSt force-pushed the stepan/HMS-10986-fix-maven-package-counts branch from ff28423 to d970cbb Compare July 9, 2026 10:46
ochosi
ochosi previously approved these changes Jul 9, 2026

@ochosi ochosi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the two parts that seem to matter most in this PR:

  • the adjusted SQL statement
  • the regular expression

Both make sense to me and should move us over to counting based on .jar files.

I will admit I did not review the tests.

@TenSt TenSt force-pushed the stepan/HMS-10986-fix-maven-package-counts branch from d970cbb to b8b7eb9 Compare July 9, 2026 11:00
@TenSt TenSt merged commit 202711e into content-services:main Jul 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants