Conversation
Signed-off-by: ainetx <[email protected]> Co-authored-by: Constructor Studio <291158726+constructor-studio[bot]@users.noreply.github.com> Studio-Generated-By: Constructor Studio Studio-Source-Repo: https://github.com/constructorfabric/studio Constructor-Fabric: https://github.com/constructorfabric Studio-Version: skill=1.0.0, cli=1.5.10 Studio-Workflows: cf-coding-review,cf-coding-fix,cf-coding-ci,cf-git-commit
📝 WalkthroughWalkthroughAgent integration path handling now resolves paths before containment checks, preserves portable and project-relative fallbacks, warns on registered-path escapes, simplifies trusted-root validation, and expands tests for fallback and warning behavior. ChangesPath Resolution Safety
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/studio/scripts/studio/commands/agents.py`:
- Around line 2292-2296: Update _warn_registered_path_escape so its warning uses
neutral wording that applies to both registered-kit paths and resource bindings,
removing the “registered kit path” terminology while preserving the existing
escape details. Update the corresponding assertion in test_agents_coverage.py to
expect the revised neutral message.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2a123050-310e-40f8-8f9e-c9b18eff69e6
📒 Files selected for processing (2)
skills/studio/scripts/studio/commands/agents.pytests/test_agents_coverage.py
Comment on lines
+2292
to
+2296
| def _warn_registered_path_escape(raw_path: str, project_root: Path, studio_root: Path) -> None: | ||
| """Warn once when neither registered-kit path base keeps *raw_path* in-project.""" | ||
| _warn_agents( | ||
| "registered kit path escapes project root after checking project and studio roots: " | ||
| f"{raw_path!r} (project={project_root.resolve()}, studio={studio_root.resolve()})" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use a path-neutral warning.
This helper is also called for resource bindings (Lines 2351-2352), but logs every rejected binding as a “registered kit path.” Use generic wording so operators investigate the correct configuration field.
Proposed fix
def _warn_registered_path_escape(raw_path: str, project_root: Path, studio_root: Path) -> None:
- """Warn once when neither registered-kit path base keeps *raw_path* in-project."""
+ """Warn once when neither registered-path base keeps *raw_path* in-project."""
_warn_agents(
- "registered kit path escapes project root after checking project and studio roots: "
+ "registered path escapes project root after checking project and studio roots: "
f"{raw_path!r} (project={project_root.resolve()}, studio={studio_root.resolve()})"
)Update the assertion at tests/test_agents_coverage.py Line 162 to match the neutral message.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| def _warn_registered_path_escape(raw_path: str, project_root: Path, studio_root: Path) -> None: | |
| """Warn once when neither registered-kit path base keeps *raw_path* in-project.""" | |
| _warn_agents( | |
| "registered kit path escapes project root after checking project and studio roots: " | |
| f"{raw_path!r} (project={project_root.resolve()}, studio={studio_root.resolve()})" | |
| def _warn_registered_path_escape(raw_path: str, project_root: Path, studio_root: Path) -> None: | |
| """Warn once when neither registered-path base keeps *raw_path* in-project.""" | |
| _warn_agents( | |
| "registered path escapes project root after checking project and studio roots: " | |
| f"{raw_path!r} (project={project_root.resolve()}, studio={studio_root.resolve()})" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/studio/scripts/studio/commands/agents.py` around lines 2292 - 2296,
Update _warn_registered_path_escape so its warning uses neutral wording that
applies to both registered-kit paths and resource bindings, removing the
“registered kit path” terminology while preserving the existing escape details.
Update the corresponding assertion in test_agents_coverage.py to expect the
revised neutral message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit