Server: add controlled shutdown support and clean status server stop#175
Open
Kaiman30 wants to merge 1 commit into
Open
Server: add controlled shutdown support and clean status server stop#175Kaiman30 wants to merge 1 commit into
Kaiman30 wants to merge 1 commit into
Conversation
Contributor
|
Hi, can you provide some details on what are you trying to achieve here? |
Author
|
Hello! I'm just learning Golang and networking, and I really like your project and just wanted to get a feel for it. I saw the "next" items in the README.MD and thought I could help. I decided to complete one to make sure you're open to offers of assistance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server.Runto its owncontext.WithCancelServer.Shutdown()runWithStatusso the status server closes when the main server closeshttp.ErrServerClosedin pkg/statusc/server.go