Skip to content

CCOR-13137 - Handle 401 + 403 (w/auth error) Gracefully#121

Open
chrishagglund-ship-it wants to merge 2 commits into
mainfrom
fix/refresh-token-when-expired
Open

CCOR-13137 - Handle 401 + 403 (w/auth error) Gracefully#121
chrishagglund-ship-it wants to merge 2 commits into
mainfrom
fix/refresh-token-when-expired

Conversation

@chrishagglund-ship-it
Copy link
Copy Markdown
Contributor

@chrishagglund-ship-it chrishagglund-ship-it commented Jun 5, 2026

CCOR-13137

Rework automatic token refresh to be more like the python implementation, (react to 403 as well, require error string in json response)

Pull Request type

  • [ x ] Bug fix

Changes in this PR

Improve handling of errors from requests that were not authorized. Prior work added reactive automatic token refresh however the implementation was naive - this should bring it up to the standards of the preferred implementation from the python sdk.

…ion, (react to 403 as well, require error string in json response)
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

❌ Patch coverage is 81.66667% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...kes/conductor/client/http/OrkesAuthentication.java 76.00% 3 Missing and 3 partials ⚠️
...conductor/client/http/TokenRefreshInterceptor.java 85.29% 4 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...main/java/io/orkes/conductor/client/ApiClient.java 15.06% <100.00%> (ø) 3.00 <0.00> (ø)
...conductor/client/http/TokenRefreshInterceptor.java 85.29% <85.29%> (ø) 11.00 <11.00> (?)
...kes/conductor/client/http/OrkesAuthentication.java 75.00% <76.00%> (+6.11%) 11.00 <2.00> (+1.00)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrishagglund-ship-it chrishagglund-ship-it changed the title https://orkes.atlassian.net/browse/CCOR-13137 CCOR-13137 - Handle 401 + 403 (w/auth error) Gracefully Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant