Skip to content

refresh auth token automatically when it expires#120

Merged
chrishagglund-ship-it merged 3 commits into
mainfrom
fix/refresh-token-when-expired
Jun 4, 2026
Merged

refresh auth token automatically when it expires#120
chrishagglund-ship-it merged 3 commits into
mainfrom
fix/refresh-token-when-expired

Conversation

@chrishagglund-ship-it

@chrishagglund-ship-it chrishagglund-ship-it commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

remove non-functioning scheduled refresh thing and replace with automatic refresh

Pull Request type

  • [ x ] Bugfix

Changes in this PR

remove broken code that refreshed token and threw it away every 45 mins, in favor of keeping the actually-working expired-cache-entry re-establisher plus newly using okhttp auth hook to freshen it in response to 401.

Alternatives considered

http interceptor but okhttp auth hook was deemed superior.

@chrishagglund-ship-it chrishagglund-ship-it changed the title remove non-functioning scheduled refresh thing and replace with autom… refresh auth token automatically when it expires Jun 2, 2026
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nductor/client/http/TokenRefreshAuthenticator.java 77.77% 2 Missing and 2 partials ⚠️
...kes/conductor/client/http/OrkesAuthentication.java 75.00% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...main/java/io/orkes/conductor/client/ApiClient.java 15.06% <100.00%> (+15.06%) 3.00 <0.00> (+3.00)
...kes/conductor/client/http/OrkesAuthentication.java 68.88% <75.00%> (+68.88%) 10.00 <2.00> (+10.00)
...nductor/client/http/TokenRefreshAuthenticator.java 77.77% <77.77%> (ø) 5.00 <5.00> (?)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrishagglund-ship-it chrishagglund-ship-it marked this pull request as ready for review June 3, 2026 17:12
@chrishagglund-ship-it chrishagglund-ship-it merged commit 0c241e0 into main Jun 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants