test: WIF auth validation for ITPC centralized pool#289
Closed
sonupreetam wants to merge 3 commits into
Closed
Conversation
sonupreetam
force-pushed
the
feat/vertex-ai-wif-integration
branch
from
f48e12e to
dab097b
Compare
sonupreetam
changed the title
sonupreetam
force-pushed
the
feat/vertex-ai-wif-integration
branch
3 times, most recently
from
d6ac8d4 to
5b24c5e
Compare
Add temporary validation workflow (ci_council_review_test.yml) that tests keyless authentication from GitHub Actions to GCP via the ITPC centralized WIF pool. Includes gate checks (skip drafts, dependabot, missing secrets), WIF auth verification, Vertex AI API access check, and Claude Code CLI connectivity test with PR comment reporting. Also gitignore internal research docs containing GCP project IDs and internal contact information. Assisted-by: Cursor (claude-opus-4-6) Signed-off-by: sonupreetam <[email protected]> Co-authored-by: Cursor <[email protected]> Signed-off-by: sonupreetam <[email protected]> Co-authored-by: Cursor <[email protected]> Signed-off-by: sonupreetam <[email protected]> Co-authored-by: Cursor <[email protected]>
sonupreetam
force-pushed
the
feat/vertex-ai-wif-integration
branch
from
5b24c5e to
95cf003
Compare
sonupreetam
changed the title
The --model sonnet flag resolves to claude-sonnet-4-5@20250929 which is not enabled on the unbound-force project. Use the explicit model ID claude-sonnet-4-6 that ITPC has enabled via SNOW request. Assisted-by: Cursor (claude-opus-4-6) Signed-off-by: sonupreetam <[email protected]> Co-authored-by: Cursor <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| steps: | ||
| - name: Authenticate to Google Cloud (ITPC WIF) | ||
| id: auth | ||
| uses: google-github-actions/auth@v3 |
| echo "ADC file: ${GOOGLE_APPLICATION_CREDENTIALS:-${CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE:-not set}}" | ||
| echo "wif_ok=true" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - uses: google-github-actions/setup-gcloud@v2 |
|
|
||
| - name: Install Claude Code | ||
| run: | | ||
| curl -fsSL https://claude.ai/install.sh | bash |
The Post test results step fails on workflow_dispatch because github.event.pull_request.number is empty. Guard the step with an event name check. Assisted-by: Cursor (claude-opus-4-6) Signed-off-by: sonupreetam <[email protected]> Co-authored-by: Cursor <[email protected]>
Contributor
Author
|
Closing: this was a one-shot WIF isolation test (expected failure). Validation complete — production workflow continues in #313. |
github-project-automation
Bot
moved this from Backlog
to Done ✔️
in ComplyTime planning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expected result: WIF auth step FAILS.
This PR tests that the ITPC centralized WIF pool correctly rejects
authentication from the
complytimeGitHub org, which has NOT beenregistered with ITPC yet (only
unbound-forceis registered).Context:
complytimeregistration to verifyisolation works
unbound-forceorg passed (PR test: validate ITPC WIF authentication from GitHub Actions unbound-force/unbound-force#235)google-github-actions/auth@v3stepAfter this fails (confirming isolation):
complytimeregistrationTest plan
Council Review Testworkflow triggers