Un-xfail test54 optional enum; add int8_t enum coverage#228
Open
conrade-ctc wants to merge 1 commit into
Open
Conversation
The upstream CPyCppyy fix (selectInstanceCnv guard for int8_t/uint8_t) makes std::optional<enum class : uint8_t> work; extend test54 to also cover enum class : int8_t (Tei8) which shares the same code path, and remove the @mark.xfail now that both are fixed. Co-developed-with-the-help-of: Claude Code (Claude Opus 4.8)
Author
|
@aaronj0 @Vipul-Cariappa, another really :easy_button: one, just undo the xfail that I already merged a fixed for some weeks ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The int8_t/uint8_t guard before
selectInstanceCnvin CPyCppyy (landed in compiler-research/CPyCppyy#205) fixedstd::optionalonenum class : uint8_t. Remove the xfail and extend test54 with theint8_t-based sibling, which shares the code path.🤖 Done with the help of Claude Code (Claude Opus 4.8)