Fix m_schar_array2 leak in test support code#227
Merged
vgvassilev merged 1 commit intoJun 13, 2026
Conversation
m_schar_array2 is new[]-allocated in the constructor alongside every other *_array2 member but was the only one missing a matching delete[] in destroy_arrays(), leaking N signed-char elements on every CppyyTestData destruction that called destroy_arrays with m_owns_arrays set. Also add missing newline at EOF. Co-developed-with-the-help-of: Claude Code (Claude Opus 4.8)
Author
|
@aaronj0 @Vipul-Cariappa, :easy_button: one, just a missing delete (which isn't exercised, but I've had sitting in my forks just in case, thought it was a good time to push up) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
destroy_arrays()deletes every 2D test array exceptm_schar_array2, which is allocated alongside them in the ctor. Add the missingdelete[].🤖 Done with the help of Claude Code (Claude Opus 4.8)