test: lock in the QT-cache alias-collision contract.#224
Open
vgvassilev wants to merge 1 commit into
Open
Conversation
cppyy's spelling-keyed converter registry deliberately routes alias-
equivalent spellings to different converters -- `unsigned char` to
UCharConverter (1-char str semantics) vs `uint8_t` to UInt8Converter
(integer semantics), both canonical to the same TCppType_t. The
canonical-QT converter cache in CPyCppyy/src/Converters.cxx skips
these alias pairs and falls back to spelling-keyed dispatch; without
the skip, sort order picks one and silently swaps str-vs-int for the
other.
Add test55_qt_cache_alias_collision asserting both semantics survive
for the two pairs that exist today (unsigned char / uint8_t and
signed char / int8_t). If a future cleanup drops the collision guard
in the populator, this test fails fast with a clear TypeError on
take_uchar(101) or take_uint8('e') instead of through one of the
existing broad-coverage tests where the failure path is harder to
read.
vgvassilev
force-pushed
the
qt-alias-collision-test
branch
from
6a4e98d to
33eafec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cppyy's spelling-keyed converter registry deliberately routes alias- equivalent spellings to different converters --
unsigned charto UCharConverter (1-char str semantics) vsuint8_tto UInt8Converter (integer semantics), both canonical to the same TCppType_t. The canonical-QT converter cache in CPyCppyy/src/Converters.cxx skips these alias pairs and falls back to spelling-keyed dispatch; without the skip, sort order picks one and silently swaps str-vs-int for the other.Add test55_qt_cache_alias_collision asserting both semantics survive for the two pairs that exist today (unsigned char / uint8_t and signed char / int8_t). If a future cleanup drops the collision guard in the populator, this test fails fast with a clear TypeError on take_uchar(101) or take_uint8('e') instead of through one of the existing broad-coverage tests where the failure path is harder to read.