Migrate to compiler-research/ci-workflows#6
Open
aaronj0 wants to merge 4 commits into
Open
Conversation
This test does not seem to pass on the downstream compres forks. CI doesn't test -stdcxx=20
Test Results
|
vgvassilev
reviewed
Jun 12, 2026
| with: | ||
| name: result-${{ matrix.os }}-llvm${{ matrix.llvm }}-py${{ matrix.python }}-cpp${{ matrix.runtime_cxx_standard }} | ||
| path: test-output.txt | ||
| - { os: ubuntu-24.04, llvm: '21', flavor: system, py: '3.14', cxx: '20', vg: true } |
Contributor
There was a problem hiding this comment.
We need name: here because it duplicates the strings and in the github ci bar it shows twice.
| - { os: macos-26, llvm: '21', flavor: system, py: '3.14', cxx: '20', vg: false } | ||
| - { os: macos-26-intel, llvm: '21', flavor: system, py: '3.14', cxx: '20', vg: false } | ||
| # cling backend, against the cached llvm-root (cling-llvm20) recipe cell. | ||
| - { os: ubuntu-24.04, llvm: '20', flavor: cling, fv: cling-llvm20, cling: true, py: '3.14', cxx: '20', vg: false } |
Contributor
There was a problem hiding this comment.
What is fv, isn't cling:true redundant?
| with: | ||
| name: result-${{ matrix.os }}-llvm${{ matrix.llvm }}-py${{ matrix.python }}-cpp${{ matrix.runtime_cxx_standard }} | ||
| path: test-output.txt | ||
| - { os: ubuntu-24.04, llvm: '21', flavor: system, py: '3.14', cxx: '20', vg: true } |
Contributor
There was a problem hiding this comment.
vg:false should be default and omitted.
| python-version: ${{ matrix.py }} | ||
| cxx-standard: ${{ matrix.cxx }} | ||
| valgrind: ${{ matrix.vg }} | ||
| run-sweeps: true |
Contributor
There was a problem hiding this comment.
This name makes no sense -- maybe run-all-crashing-tests or something is better.
| @@ -0,0 +1,76 @@ | |||
| # Configures the CppInterOp ExternalProject. Default backend is clang-repl; | |||
Contributor
There was a problem hiding this comment.
Why do we need this file? If it has something to do with the ci, then then it defeats the purpose of the ci-workflows changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus some minor developments, extending to a Cling backend and adding configuration files for a modular CI setup. This system moves to using the reusable actions from ci-workflows () and creates a build matrix for PR runs and extended coverage for nightlies. This PR will be followed up with the pre-commit and lint workflows before opening a PyPI workflow to build Python wheels. Note that the std::span test fails for me locally, also with the 3-repo setup so it needs to be resolved before deprecating the forks.
Depends on http://github.com/compiler-research/ci-workflows/pull/80