Array and map FFIs, lots of cleanups#14
Merged
Merged
Conversation
…test cogen. Completed Scala upgrade of FFIs. Unable to generate bottom up since Arrays are not fully integrated into types.
…ll over the place.
works for bottomUp, topDown, topDownMemo in Glossary
Problem: we need a default value for the element type of the (nested) arrays.
Completed multi-dimen arrays in Scala/inbetween. Might be a bit sloppy. Confirmed works for BellNumber output in both Java and Scala. Still have a problem with init fields in methods in Scala (see hello World scala, which doesn't )
… make it easy to generate all Java or all Scala. Note: Test cases in scala for MinPathSum do not properly generate and this is a scala/array problem since it works in java
…es and tests properly for Glossary in Java and Scala.
…means you can remove new operator for them all. be careful not when using EqualExpression to compare two character types, since you need to pass in the third argument which is the non-integer type.
…means you can remove new operator for them all. be careful not when using EqualExpression to compare two character types, since you need to pass in the third argument which is the non-integer type. Added Maps as new FFI
…n, but as with the Maps extension, work remains. Addressed WordBreak and NeedleMan which each need their own independent provide, since tests are not yet generic enough to be able to support extensions.
…th test cases. All of the chimeric LiteralXYZ classes are relegated to the archive.* subpackage for older implementations. Now use LiteraTuple() to combine multiple values in test cases. Continued to work on Map (added ContainsKeyOp) though it still doesn't fully work in Scala. Added GridWithObstacles DP problem and solution. Started NumberPathsWithKCoins but this needs work.
…wice. Added test case to CountSquares
Confirmed able to generate both Scala and Java expression problem code, validating compilation and test cases.
… Domain, Language, and EP Approach.
Still need to fix exceptions. Still has problems with topDownWithMemo in Java because we need new scheme to update properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds proper Map<A, B> FFIs, fixes Array FFIs, cleans dynamic programming code, fixes various ffi bugs.