Modernize for PHP 8.1+ and PHPUnit 11 by joanfabregat · Pull Request #2 · codeinchq/strip-accents

joanfabregat · 2026-04-15T18:33:41Z

Summary

Drop PHP 7.x support, require PHP 8.1+ with ext-mbstring
Upgrade PHPUnit from ^7 to ^11 (resolves Dependabot alert #1 — CVE-2026-24765)
Modernize source code: PHP 8.4 typed constants, trailing commas, clean docblocks
Rewrite tests with #[DataProvider] attributes, assertSame assertions, and full coverage of strip(), stripNonPrint(), ligatures, edge cases
Add phpunit.xml.dist configuration
Add GitHub Actions CI workflow (PHP 8.1–8.4 matrix) for pushes and PRs
Update README with Packagist badges and modern usage examples

Test plan

All 60 tests pass on PHP 8.3 (verified in ephemeral container)
CI workflow runs on this PR across PHP 8.1–8.4

🤖 Generated with Claude Code

Drop PHP 7.x support, require PHP 8.1+. Update PHPUnit from ^7 to ^11 (fixes CVE-2026-24765 Dependabot alert). Modernize source with typed constants and trailing commas. Rewrite tests with data providers and proper assertions. Add phpunit.xml.dist, CI workflow for PRs, and Packagist badges to README. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Copilot

Pull request overview

This PR modernizes the library for newer PHP/PHPUnit versions by updating platform constraints, refreshing the implementation and test suite, and adding CI + PHPUnit configuration.

Changes:

Bump requirements to PHP 8.1+ (plus ext-mbstring) and upgrade PHPUnit to ^11.
Modernize StripAccents + expand/rewrite tests using PHPUnit attributes and more explicit assertions.
Add PHPUnit config (phpunit.xml.dist) and a GitHub Actions CI workflow to run tests across multiple PHP versions.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`src/StripAccents.php`	Modernized implementation and constants; reformatted `stripNonPrint()` signature.
`tests/StripAccentsTest.php`	Rewritten tests with a data provider + added coverage for edge cases/ligatures/`stripNonPrint()`.
`phpunit.xml.dist`	New PHPUnit 11 configuration (bootstrap, cache dir, source include).
`composer.json`	Drops PHP 7.x, requires PHP 8.1+ and `ext-mbstring`, upgrades PHPUnit dev requirement.
`README.md`	Updated docs with badges and modern examples (incl. named args).
`.gitignore`	Ignores PHPUnit cache directory.
`.github/workflows/ci.yml`	Adds CI job running PHPUnit in a PHP version matrix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-15T18:37:04Z

+// "ABC AEY "

-// You can specify any encoding supported by htmlentities() as a second parameter
-echo StripAccents::strip("A strïng with àccénts", "iso-8859-1");
+echo StripAccents::stripNonPrint("ABC ÀÈÝ 是我这", replaceWith: "-");
+// "ABC AEY ---"


The example output for stripNonPrint(..., replaceWith: "-") appears incorrect for the current implementation: the regex runs byte-wise (no /u modifier), so each 3-byte CJK character becomes 3 replacements (the tests assert 9 - total). Update the README example to match actual behavior, or clarify/document a character-wise replacement approach if that’s the intent.

Copilot · 2026-04-15T18:37:05Z

+    branches: [master]
+  pull_request:
+    branches: [master]


The workflow is restricted to branches: [master]. If the default branch is main (as suggested by the PR diff base), CI won’t run for pushes/PRs to the default branch. Consider switching this filter to the actual default branch name or removing the branch filter to ensure CI runs on all PRs.

Suggested change

branches: [master]

pull_request:

branches: [master]

branches: [main]

pull_request:

branches: [main]

Copilot · 2026-04-15T18:37:05Z

+
+    strategy:
+      matrix:
+        php-version: ['8.1', '8.2', '8.3', '8.4']


CI runs PHP 8.1/8.2, but the code in this PR uses typed class constants (PHP 8.3+). Either drop 8.1/8.2 from the matrix or adjust the code/composer constraints so the matrix matches the supported PHP versions.

Suggested change

php-version: ['8.1', '8.2', '8.3', '8.4']

php-version: ['8.3', '8.4']

Copilot · 2026-04-15T18:37:05Z

+composer require codeinc/strip-accents
+```
+
+Requires PHP 8.1 or later.


README requirement statement is incomplete/inconsistent with composer.json: the package now requires ext-mbstring, but the README only mentions the PHP version. Also, if typed class constants remain, the minimum PHP version becomes 8.3+. Please align the README requirements with the actual composer/platform constraints.

Suggested change

Requires PHP 8.1 or later.

Requires PHP 8.3 or later with the `mbstring` extension enabled.

Copilot · 2026-04-15T18:37:06Z

 class StripAccents
 {
-    public const DEFAULT_ENCODING = 'utf-8';
+    private const string DEFAULT_ENCODING = 'utf-8';


private const string DEFAULT_ENCODING uses typed class constants, which are not supported in PHP 8.1/8.2. With the current composer.json requirement (php >=8.1) and CI matrix including 8.1/8.2, this will cause a parse error on those versions. Either remove the constant type declarations, or bump the minimum PHP version (and update README/CI accordingly).

Suggested change

private const string DEFAULT_ENCODING = 'utf-8';

private const DEFAULT_ENCODING = 'utf-8';

Copilot · 2026-04-15T18:37:06Z

-        'I', 'O', 'O', 'O', 'O', 'O', 'U', 'U', 'U', 'U', 'Y', 'a', 'a', 'a',
-        'a', 'a', 'a', 'c', 'e', 'e', 'e', 'e', 'i', 'i', 'i', 'i', 'e', 'o',
-        'o', 'o', 'o', 'o', 'u', 'u', 'u', 'u', 'y', 'y'
+    private const array ACCENT_MAP = [


private const array ACCENT_MAP uses typed class constants, which are not supported in PHP 8.1/8.2. Since the PR targets PHP 8.1+ (and CI tests 8.1/8.2), this will make the test suite fail to even parse on those versions. Either remove the type from the constant or raise the project’s minimum PHP version and align CI/README.

Suggested change

private const array ACCENT_MAP = [

private const ACCENT_MAP = [

Remove typed class constants (PHP 8.3+ only) to maintain PHP 8.1+ compatibility. Document mbstring requirement and correct stripNonPrint example output in README. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

PHPUnit 11 requires PHP 8.2+, so drop 8.1 from the matrix and bump the composer constraint accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Keep backward compatibility with existing consumers that may reference StripAccents::DEFAULT_ENCODING directly. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Copilot AI review requested due to automatic review settings April 15, 2026 18:33

Copilot started reviewing on behalf of joanfabregat April 15, 2026 18:34 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

joanfabregat and others added 3 commits April 15, 2026 11:38

Fix Copilot review: drop typed constants, fix README

93e2f17

Remove typed class constants (PHP 8.3+ only) to maintain PHP 8.1+ compatibility. Document mbstring requirement and correct stripNonPrint example output in README. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Bump minimum PHP to 8.2 (PHPUnit 11 requirement)

9558a6e

PHPUnit 11 requires PHP 8.2+, so drop 8.1 from the matrix and bump the composer constraint accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Restore public visibility of DEFAULT_ENCODING constant

ea09e7f

Keep backward compatibility with existing consumers that may reference StripAccents::DEFAULT_ENCODING directly. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

joanfabregat merged commit 66c8214 into master Apr 15, 2026
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize for PHP 8.1+ and PHPUnit 11#2

Modernize for PHP 8.1+ and PHPUnit 11#2
joanfabregat merged 4 commits into
masterfrom
modernize-php8

joanfabregat commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	php-version: ['8.1', '8.2', '8.3', '8.4']
	php-version: ['8.3', '8.4']

	Requires PHP 8.1 or later.
	Requires PHP 8.3 or later with the `mbstring` extension enabled.

	private const string DEFAULT_ENCODING = 'utf-8';
	private const DEFAULT_ENCODING = 'utf-8';

	private const array ACCENT_MAP = [
	private const ACCENT_MAP = [

Conversation

joanfabregat commented Apr 15, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants