fix: speed up mobile reader TOC#588
Open
codedogQBY wants to merge 1 commit into
Open
Conversation
Owner
Author
|
补充一份更细的验证 checklist,方便合并前复核: 已执行:
已知阻塞,不归这个 PR:
建议真机回归:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #576
Fixes #168
Analysis
The Android report in #576 points to two related problems: opening/closing a 2000-chapter TOC takes seconds, and the sheet always starts from chapter one even when the reader is around chapter 1200. The old panel recursively rendered the entire visible TOC tree inside ScrollView, so simple flat TOCs created all rows at once and closing the modal also had to unmount them. It also only highlighted by chapter title and never scrolled to the active item.
This PR virtualizes the list and uses the reader relocate href to find the active TOC row, then scrolls there on open.
Verification