Skip to content

fix(cache): replace custom ETag strategy with OkHttp native cache #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jun 26, 2026
Merged

fix(cache): replace custom ETag strategy with OkHttp native cache #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions apps/flipcash/app/src/main/kotlin/com/flipcash/app/FlipcashApp.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,12 @@ import androidx.work.Configuration
import coil3.ImageLoader
import coil3.PlatformContext
import coil3.SingletonImageLoader
import coil3.annotation.ExperimentalCoilApi
import coil3.disk.DiskCache
import coil3.disk.directory
import coil3.network.okhttp.OkHttpNetworkFetcherFactory
import coil3.request.CachePolicy
import coil3.request.crossfade
import com.flipcash.app.auth.AuthManager
import com.flipcash.app.core.cache.ETagCacheStrategy
import com.flipcash.app.core.cache.ETagOfflineFallbackInterceptor
import okhttp3.Cache
import okhttp3.OkHttpClient
import com.flipcash.app.currency.PreferredCurrencyController
import com.getcode.opencode.repositories.EventRepository
import com.getcode.utils.trace
Expand Down Expand Up @@ -53,23 +50,16 @@ class FlipcashApp : Application(), Configuration.Provider, SingletonImageLoader.
trace("app onCreate end")
}

@OptIn(ExperimentalCoilApi::class)
override fun newImageLoader(context: PlatformContext): ImageLoader {
val okHttpClient = OkHttpClient.Builder()
.cache(Cache(context.cacheDir.resolve("http_image_cache"), 50L * 1024 * 1024))
.build()
return ImageLoader.Builder(context)
.crossfade(true)
.memoryCachePolicy(CachePolicy.ENABLED)
.diskCachePolicy(CachePolicy.ENABLED)
.diskCache {
DiskCache.Builder()
.directory(context.cacheDir.resolve("image_cache"))
.maxSizePercent(0.2)
.build()
}
.diskCachePolicy(CachePolicy.DISABLED)
.components {
add(ETagOfflineFallbackInterceptor())
add(OkHttpNetworkFetcherFactory(
cacheStrategy = { ETagCacheStrategy() },
))
add(OkHttpNetworkFetcherFactory(callFactory = { okHttpClient }))
}
.build()
}
Expand Down
151 changes: 0 additions & 151 deletions apps/flipcash/core/src/main/kotlin/com/flipcash/app/core/cache/ETagRevalidation.kt
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions apps/flipcash/core/src/main/kotlin/com/flipcash/app/core/ui/TokenImageWithName.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import coil3.compose.LocalPlatformContext
import coil3.request.ImageRequest
import coil3.request.crossfade
import coil3.request.error
import com.flipcash.app.core.cache.etagRevalidation
import com.getcode.opencode.model.financial.Token
import com.getcode.theme.CodeTheme
import com.getcode.ui.components.R
Expand Down Expand Up @@ -108,7 +107,6 @@ fun TokenIcon(
.data(image)
.crossfade(false)
.error(R.drawable.ic_placeholder_user)
.etagRevalidation()
.build(),
contentDescription = null,
contentScale = ContentScale.Crop,
Expand Down
Loading
Loading