fix(chat): prevent delta sync from regressing lastActivity#989
Merged
Conversation
A partial-page delta sync (e.g. when latestEventSequence is 0 and the server returns only the first 100 of 125 messages) would overwrite lastActivity with the timestamp of the oldest page's latest message, causing the chat to drop in feed sort order. Now the delta sync only advances lastActivity, never regresses it.
Signed-off-by: Brandon McAnsh <[email protected]>
Signed-off-by: Brandon McAnsh <[email protected]>
github-actions
Bot
added
area: onramp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partial-page delta sync (e.g. when latestEventSequence is 0 and the
server returns only the first 100 of 125 messages) would overwrite
lastActivity with the timestamp of the oldest page's latest message,
causing the chat to drop in feed sort order.
Now the delta sync only advances lastActivity, never regresses it.