feat(cache): add ETag-based image cache revalidation for Coil#988
Merged
Conversation
Token icons from currency-assets lack Cache-Control headers, so Coil's default strategy serves stale disk-cached images indefinitely. Add an opt-in ETagCacheStrategy that sends If-None-Match / If-Modified-Since conditional headers, letting the server respond 304 when unchanged. An offline fallback interceptor retries without revalidation so cached icons still display when the network is unavailable. Signed-off-by: Brandon McAnsh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token icons from currency-assets lack Cache-Control headers, so Coil's default strategy serves stale disk-cached images indefinitely. Add an opt-in ETagCacheStrategy that sends If-None-Match / If-Modified-Since conditional headers, letting the server respond 304 when unchanged. An offline fallback interceptor retries without revalidation so cached icons still display when the network is unavailable.