fix(streaming): stop reporting retryable ClosedSendChannelException to Bugsnag#978
Merged
Merged
Conversation
…o Bugsnag The initial-request send in openBidirectionalStream already treats ClosedSendChannelException as retryable, but the trace() call was passing `error = e` which routed through ErrorUtils → Bugsnag.notify(). Inline the message instead so the retry path no longer produces false-positive Bugsnag warnings. Signed-off-by: Brandon McAnsh <[email protected]>
github-actions
Bot
added
area: network
bmc08gt
added a commit
that referenced
this pull request
Jun 24, 2026
…inator-delegates * origin/code/cash: feat(messaging): integrate updated chat protos with data layer and tests (#976) fix(streaming): stop reporting retryable ClosedSendChannelException to Bugsnag (#978) build: update release manifest # Conflicts: # apps/flipcash/shared/chat/src/main/kotlin/com/flipcash/shared/chat/ChatCoordinator.kt # apps/flipcash/shared/chat/src/test/kotlin/com/flipcash/shared/chat/ChatCoordinatorEventsTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial-request send in openBidirectionalStream already treats ClosedSendChannelException as retryable, but the trace() call was passing
error = ewhich routed through ErrorUtils → Bugsnag.notify(). Inline the message instead so the retry path no longer produces false-positive Bugsnag warnings.