build(gradle): enable configuration cache, drop configuration-on-demand#972
Merged
bmc08gt merged 3 commits intoJun 24, 2026
Merged
Conversation
Turn on org.gradle.configuration-cache and remove the now-superseded org.gradle.configureondemand (configuration-on-demand is incompatible with the configuration cache). Builds on the cross-project config removal from code-payments#971, which cleared the root-script barriers to a cacheable configuration phase. Validated locally: full configuration of all modules succeeds with zero configuration-cache problems, the entry is reused across runs, and a module unit test executes and reuses the cache. Problems fail the build by default, so CI enforces a clean configuration phase. This is also the prerequisite for enabling Isolated Projects later.
Replace cross-project root access that Isolated Projects forbids with the IP-safe equivalents, without changing behavior: - compose convention plugin & app: rootProject.layout.projectDirectory -> isolated.rootProject.projectDirectory for the stability config file. - ContributorsSignatory: take the root directory as a File instead of a Project, so callers no longer invoke Project.file on the root project. Path resolution is unchanged (relative against root, absolute as-is). Verified under the configuration cache (already enabled): full configuration succeeds with zero problems and the entry reuses cleanly. With these in place, flipping org.gradle.unsafe.isolated-projects drops from 356 problems to a single remaining AGP-internal access in com.android.application, which is upstream and will clear with a future AGP that fully supports Isolated Projects. The IP flag stays off until then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn on org.gradle.configuration-cache and remove the now-superseded
org.gradle.configureondemand (configuration-on-demand is incompatible with
the configuration cache). Builds on the cross-project config removal from
#971, which cleared the root-script barriers to a cacheable configuration
phase.