fix: debounce network-state subscription to connected boolean only#958
Merged
Conversation
…an only The ContactCoordinator subscribed to the full NetworkState (connected + signalStrength + type). Signal-strength or connection-type fluctuations passed through distinctUntilChanged() and each triggered a full contact sync — up to 44 times in 270ms during a charger-connect event. Fix: map to just the connected boolean before distinctUntilChanged so only actual connectivity transitions trigger sync. Bugsnag: 6a3686f3d2c3b94118b56442
…initial send When the gRPC response flow errors immediately after creation, the .catch block closes the requestChannel before send(initialRequest()) completes, throwing ClosedSendChannelException. This is a transient condition (the stream died during setup) and should always be retried. Previously this was treated as a terminal error, reported to Bugsnag, and the stream gave up. Now it continues the retry loop, bounded by maxReconnectAttempts. Bugsnag: 6a3686f3d2c3b94118b56442 Signed-off-by: Brandon McAnsh <[email protected]>
github-actions
Bot
added
type: fix
AccountController and TokenCoordinator had the same bug as ContactCoordinator — subscribing to the full NetworkState instead of just the connected boolean, causing redundant work on signal-strength or connection-type changes. AccountController was worse: no distinctUntilChanged at all, so every NetworkState emission triggered fetchAdditionalAccountInfo(). Bugsnag: 6a3686f3d2c3b94118b56442 Signed-off-by: Brandon McAnsh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.