fix(auth): skip network retries during offline cold launch#1004
Merged
Conversation
Check connectivity before retrying getUserFlags(), updateUserProfile(), and savePrefs() in login(). When offline during a soft login (app restart), flags resolve to null immediately and the existing local fallback sets AuthState.Ready from cached DataStore — eliminating the ~6s spinner caused by 3 failed retries with 2s delays. Interactive logins still always attempt the network fetch. Data refreshes on reconnect via RealSessionController. Signed-off-by: Brandon McAnsh <[email protected]>
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check connectivity before retrying getUserFlags(), updateUserProfile(), and savePrefs() in login(). When offline during a soft login (app restart), flags resolve to null immediately and the existing local fallback sets AuthState.Ready from cached DataStore — eliminating the ~6s spinner caused by 3 failed retries with 2s delays. Interactive logins still always attempt the network fetch. Data refreshes on reconnect via RealSessionController.