fix: revise failure must not show Done/已完成 - #143
Merged
Conversation
ReviseInPlace errors were persisted and streamed as successful turn_done, so chat footnotes still showed 已完成/Done. Share Interrupted with cancel and emit turn_done+interrupted:true while keeping the session retryable. Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
executeReviewTurn: ont.Err != nil, persist agentInterrupted=trueand returntrue, nilso pump emitsturn_done+interrupted:true(same UI path as cancel).(复审修改失败:…)remains visible; enqueue still succeeds; outputs are not refreshed; Run/node are not failed.Review
Test plan
go test ./internal/engine/ -run TestReviewReplyFailureDoesNotSyncOutputsnpm test -- ClarifyChat/GateApproval/ReviewComposer/ThoughtSummaryStatus(failure + interrupted cases)