refactor: align with AD4M resolveLiteral API (companion to coasys/ad4m#842)#78
Open
HexaField wants to merge 1 commit into
Open
refactor: align with AD4M resolveLiteral API (companion to coasys/ad4m#842)#78HexaField wants to merge 1 commit into
HexaField wants to merge 1 commit into
Conversation
…nguage Co-Authored-By: Claude Opus 4.6 <[email protected]>
❌ Deploy Preview for coasys-we failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR to coasys/ad4m#842 — updates the WE codebase to use the new
resolveLiteral: booleandecorator property in place of the removedresolveLanguage: string.Changes
Model decorators (7 files, 12 properties)
resolveLanguage: FILE_STORAGE_LANGUAGE→resolveLiteral: falseon all file-storage@PropertydecoratorsFILE_STORAGE_LANGUAGEimports from model files (Theme, Template, Space, ImageBlock, FileBlock, CollectionBlock, AudioBlock)Runtime metadata reads (serialization.ts)
preUploadFileAssets(): detection changed frommeta.resolveLanguagetometa.resolveLiteral === false;createExpressioncall now uses importedFILE_STORAGE_LANGUAGEconstant directly (sinceresolveLiteralis boolean and doesn't carry the language address)resolveExpressionAddresses(): same detection change for the read-side counterpartType definitions
ModelManifestProperty.resolveLanguage?: string→resolveLiteral?: boolean(AdamStore.tsx)p.resolveLiteral(perspectiveHelpers.ts)Comments
Notes
FILE_STORAGE_LANGUAGEconstant remains exported from@we/models— it's still used byagentHelpers.ts(profile image uploads) and now byserialization.ts(block file-asset uploads).get().data→.get()) was already correct in the codebase — no change neededTest plan
@coasys/ad4mwithresolveLiteralsupportpreUploadFileAssetscorrectly detects and uploads FileDataresolveExpressionAddressescorrectly resolves CIDs to data URIsresolveLiteralfrom shapes🤖 Generated with Claude Code