chore: migrate repository checks and update Midge#81
Merged
smiggleworth merged 1 commit intoJul 25, 2026
Conversation
smiggleworth
deleted the
chore/migrate-repository-checks-and-update-midge
branch
July 25, 2026 17:02
There was a problem hiding this comment.
Pull request overview
This PR migrates Fitz’s repository-level CI/repository policy checks to cntryl-tools, pins the cntryl-midge dependency to a specific merged commit, and updates documentation/workflows to satisfy the new generic validation gates.
Changes:
- Pin
cntryl-midgeto commit29fa79788d5fcf04ea87f83b42c9997ab5764716and update the lockfile accordingly. - Install and run
cntryl-toolsvalidators in backend CI and benchmark workflows. - Add
.cntryl/repository.tomland adjust docs/bench workflow text/links to match the new policy checks.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/development/route-design.md | Updates code-location references in route-design docs (needs corrections for KV parsing and RPC codec locations). |
| docs/development/perf-loop.md | Adjusts benchmark guideline link target. |
| docs/development/benchmarks.md | Adds an explicit “not a pull-request performance gate” statement for benchmark workflow policy. |
| docs/clients/spec/wire-routing.md | Simplifies RPC-domain link target in client wire spec docs. |
| Cargo.toml | Pins cntryl-midge to a specific git revision. |
| Cargo.lock | Updates resolved dependency graph for the pinned Midge commit. |
| .github/workflows/ci-backend.yml | Installs cntryl-tools and runs repository policy validators in backend CI. |
| .github/workflows/bench.yml | Installs cntryl-tools, validates benchmark contract, and tweaks bench command flags/order (cache ordering should be fixed). |
| .cntryl/repository.toml | Introduces repository policy configuration for required docs, benchmark contract, and module-size checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #### Parsing Logic | ||
|
|
||
| Location: [src/protocol/kv_codec/mod.rs](../../src/protocol/kv_codec/mod.rs) | ||
| Location: [src/domains/kv/protocol.rs](../../src/domains/kv/protocol.rs) |
| | KV | [domains/kv/protocol.rs](../../src/domains/kv/protocol.rs) | [domains/kv/actor.rs](../../src/domains/kv/actor.rs) | [protocol/kv_codec/mod.rs](../../src/protocol/kv_codec/mod.rs) | [domains/kv/session.rs](../../src/domains/kv/session.rs) | | ||
| | Queue | [domains/queue/protocol.rs](../../src/domains/queue/protocol.rs) | [domains/queue/actor/mod.rs](../../src/domains/queue/actor/mod.rs) | [protocol/queue_codec.rs](../../src/protocol/queue_codec.rs) | [domains/queue/sink/mod.rs](../../src/domains/queue/sink/mod.rs) | | ||
| | RPC | [domains/rpc/protocol.rs](../../src/domains/rpc/protocol.rs) | [domains/rpc/actor.rs](../../src/domains/rpc/actor.rs) | [protocol/rpc_codec.rs](../../src/protocol/rpc_codec.rs) | [domains/rpc/session.rs](../../src/domains/rpc/session.rs) | | ||
| | RPC | [domains/rpc/mod.rs](../../src/domains/rpc/mod.rs) | [domains/rpc/mod.rs](../../src/domains/rpc/mod.rs) | [domains/rpc/protocol.rs](../../src/domains/rpc/protocol.rs) | [domains/rpc/sink/mod.rs](../../src/domains/rpc/sink/mod.rs) | |
Comment on lines
+23
to
+27
| - name: Install cntryl-tools | ||
| run: cargo install --locked --git https://github.com/cntryl/tools --rev b2a06b1a635de752803f5860339fc3cecbc19742 cntryl-tools | ||
|
|
||
| - name: Validate benchmark contract | ||
| run: cntryl-tools validate-benchmarks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
Summary:
Risk:
Verification:
The full cargo test --locked --workspace --all-features run compiled and entered runtime tests but did not finish locally after duplicate runs; the local processes were stopped.