Skip to content

Specific variable plotting bugfix#99

Merged
kandrosov merged 16 commits into
cms-flaf:mainfrom
thorntoa-tamu:specific_variable_plotting_bugfix
Jul 14, 2026
Merged

Specific variable plotting bugfix#99
kandrosov merged 16 commits into
cms-flaf:mainfrom
thorntoa-tamu:specific_variable_plotting_bugfix

Conversation

@thorntoa-tamu

Copy link
Copy Markdown
Contributor

added histograms for more MT2 variables

Alexander Forshay Thornton and others added 12 commits June 26, 2026 10:25
- Rename MT2_blbl → MT2_blbl1 (l1b1+l2b2 pairing) for clarity
- Add MT2_blbl1/2_delta_phi and MT2_blbl1/2_ptratio observables
- Update histogram configs, global variables list, and DNN feature configs accordingly
- Remove jj_dphi from variables list (was never defined, would cause crash)
@thorntoa-tamu

Copy link
Copy Markdown
Contributor Author

@cms-flaf-bot please test

@cms-flaf-bot

Copy link
Copy Markdown

pipeline#15187777 started

@cms-flaf-bot

Copy link
Copy Markdown

pipeline#15187777 passed

@kandrosov kandrosov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove variables from ci_custom. In this way all variables from global yaml will be tested by CI to avoid similar bugs in future.

@thorntoa-tamu

Copy link
Copy Markdown
Contributor Author

remove variables from ci_custom. In this way all variables from global yaml will be tested by CI to avoid similar bugs in future.

Got it!

@thorntoa-tamu

Copy link
Copy Markdown
Contributor Author

remove variables from ci_custom. In this way all variables from global yaml will be tested by CI to avoid similar bugs in future.

Wait, do you mean user_custom.yaml, or ci_custom.yaml? User_custom is where I have all the MT2 vars, I've not touched ci_custom and seems to just store DNN variables.

@kandrosov

Copy link
Copy Markdown
Contributor

remove these lines from ci_custom https://github.com/cms-flaf/HH_bbWW/blob/main/config/ci_custom.yaml#L19-L30

@thorntoa-tamu

Copy link
Copy Markdown
Contributor Author

remove these lines from ci_custom https://github.com/cms-flaf/HH_bbWW/blob/main/config/ci_custom.yaml#L19-L30

This is a local custom config file, correct? Does the CI test from the bot take this into account? If this isn't true, then I'm not sure I follow how the CI "knows" that all variables should be tested.

@thorntoa-tamu

Copy link
Copy Markdown
Contributor Author

@cms-flaf-bot please test

@cms-flaf-bot

Copy link
Copy Markdown

pipeline#15227418 started

@cms-flaf-bot

Copy link
Copy Markdown

pipeline#15227418 passed

@thorntoa-tamu

Copy link
Copy Markdown
Contributor Author

@cms-flaf-bot please test

@cms-flaf-bot

Copy link
Copy Markdown

pipeline#15228233 started

@cms-flaf-bot

Copy link
Copy Markdown

pipeline#15228233 failed

@thorntoa-tamu

Copy link
Copy Markdown
Contributor Author

@cms-flaf-bot please test

@cms-flaf-bot

Copy link
Copy Markdown

pipeline#15229581 started

@thorntoa-tamu

Copy link
Copy Markdown
Contributor Author

@cms-flaf-bot please test

@cms-flaf-bot

Copy link
Copy Markdown

pipeline#15269859 started

@cms-flaf-bot

Copy link
Copy Markdown

pipeline#15269859 passed

@kandrosov
kandrosov merged commit 41f093d into cms-flaf:main Jul 14, 2026
4 checks passed
@aebid

aebid commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@kandrosov do you think this new "run on all variables" is acceptable? It moved the CI test from ~30 minutes (https://gitlab.cern.ch/cms-flaf/flaf_integration/-/pipelines/15227418) to almost 2 hours (https://gitlab.cern.ch/cms-flaf/flaf_integration/-/pipelines/15269859).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants