fix(volo-http): return reusable HTTP/1 connections from the driver - #663
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
==========================================
+ Coverage 50.23% 51.21% +0.97%
==========================================
Files 163 163
Lines 20588 21003 +415
==========================================
+ Hits 10342 10756 +414
- Misses 10246 10247 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Joshuahoky
reviewed
Aug 13, 2026
shenyj3
reviewed
Aug 13, 2026
junliurs
force-pushed
the
fix/http1-managed-connection-reuse
branch
3 times, most recently
from
August 13, 2026 12:32
7f468e0 to
5cc45b3
Compare
shenyj3
previously approved these changes
Aug 14, 2026
junliurs
force-pushed
the
fix/http1-managed-connection-reuse
branch
from
August 17, 2026 03:46
5cc45b3 to
c9fdbc6
Compare
Move the HTTP/1 sender between the pool, request future, and connection driver through a return channel. Reinsert the connection only after Hyper reports it ready, while preserving cancellation safety and the existing response body fast path.
junliurs
force-pushed
the
fix/http1-managed-connection-reuse
branch
from
August 17, 2026 04:02
c9fdbc6 to
7d5b1fc
Compare
shenyj3
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the HTTP/1 sender between the pool, request future, and connection driver through a return channel. Reinsert the connection only after Hyper reports it ready, while preserving cancellation safety and the existing response body fast path.
Motivation
Solution