Configure pkgconf with multiarch pkg-config and library search paths#115
Merged
Conversation
The original pkg-config build included --with-pc-path to search /usr/lib/x86_64-linux-gnu/pkgconfig. When switching to pkgconf, the equivalent --with-pkg-config-dir flag was not included, so pkgconf omitted the multiarch path from its compiled-in defaults. On ubuntu-noble, cmake 3.28's FindOpenSSL uses pkg-config to resolve the library directory hint. Without openssl.pc visible to pkgconf, cmake could not locate OPENSSL_CRYPTO_LIBRARY despite libssl-dev being installed, causing the percona-xtrabackup builds to fail at the libkmip cmake configure step.
kimago
approved these changes
Jun 8, 2026
kimago
left a comment
Member
There was a problem hiding this comment.
Reasonable changes to package builds exclusively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original pkg-config build included --with-pc-path to search /usr/lib/x86_64-linux-gnu/pkgconfig. When switching to pkgconf, the equivalent --with-pkg-config-dir flag was not included, so pkgconf omitted the multiarch path from its compiled-in defaults.
On ubuntu-noble, cmake 3.28's FindOpenSSL uses pkg-config to resolve the library directory hint. Without openssl.pc visible to pkgconf, cmake could not locate OPENSSL_CRYPTO_LIBRARY despite libssl-dev being installed, causing the percona-xtrabackup builds to fail at the libkmip cmake configure step.
This was a regression introduced by #107 and only visible under ubuntu-noble compilation which was not caught before the merge.