Skip to content

Fix image builds#2751

Merged
aramprice merged 6 commits into
mainfrom
fix-cpi-images
Jun 25, 2026
Merged

Fix image builds#2751
aramprice merged 6 commits into
mainfrom
fix-cpi-images

Conversation

@aramprice

Copy link
Copy Markdown
Member

Update how base_image is retrieved now that we are using registry-image / build-oci-image task

Copilot AI review requested due to automatic review settings June 25, 2026 19:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8cb243a2-6bc8-4d00-8989-5c2d958db0e6

📥 Commits

Reviewing files that changed from the base of the PR and between 79ff07b and 86d993e.

📒 Files selected for processing (1)
  • src/tasks/spec.rake

Walkthrough

The pipeline adds an all job group containing every job. Several build jobs now fetch integration-image with format: oci. The main postgres and mysql build jobs use integration-image/image.tar as IMAGE_ARG_BASE_IMAGE, and the docker and warden CPI build jobs switch copy-dependencies to ubuntu-registry-image. The integration spec task now starts with an empty rspec_opts array.

Suggested reviewers

  • KauzClay
  • fmoehler
  • selzoc
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the change but omits the required template sections for context, tests, release notes, breaking changes, and team tags. Expand the PR body to fill all template sections: change summary, context, tests run, release note text, breaking-change status, and tags.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: image build pipeline updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-cpi-images

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 25, 2026
This doesn't make sense because the image won't have been pushed
if the image build didn't succeed
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 25, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 25, 2026
@aramprice aramprice requested review from a team, a-hassanin and mariash and removed request for a team June 25, 2026 19:58
KauzClay
KauzClay previously approved these changes Jun 25, 2026
@aramprice aramprice dismissed stale reviews from KauzClay and coderabbitai[bot] via 86d993e June 25, 2026 20:09
@aramprice aramprice merged commit 2588691 into main Jun 25, 2026
22 checks passed
@aramprice aramprice deleted the fix-cpi-images branch June 25, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants