feat(wrangler): report startup profile summary - #14893
Conversation
🦋 Changeset detectedLatest commit: da3cc34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
Now let me consider the Let me look at whether there's a division-by-zero or NaN risk when Let me verify the final concern about I've completed a thorough review. Let me summarize findings:
The only truly minor nit (redundant LGTM |
|
✅ All changesets look good |
@cloudflare/autoconfig
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Regarding the docs I assume we want to update this page? https://developers.cloudflare.com/workers/wrangler/commands/workers/#check 🤔 |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Very Nice! 🤩
Approving although the docs still need to be updated I think?
PS: feel free to ignore the Vite plugin E2E failures, those are unrelated to this PR and we're looking into fixing them
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Thank you, and yup I'll get a docs PR up tomorrow! |
|
@apeacock1991 The Vite plugin E2Es issue has been fixed in #14895, please rebase the PR to fix those failures there 😄 |
4413408 to
da3cc34
Compare
Show key performance metrics in the output of
wrangler check startup, notably:The latter can be extracted from the flamegraph, but it seems nice to just show them directly in the output vs have to fish. Adding bundle size as it's another key start up metric that can greatly affect start up speed.
I will raise a docs PR for this if it's deemed good/reasonable to merge