Re-export url::ParseError alongside url::Url#1033
Open
eyupcanakman wants to merge 1 commit into
Open
Conversation
`Url::parse` returns `Result<Url, ParseError>` and `Error` already has a `From<url::ParseError>` impl, but the error type itself was never re-exported. Naming it meant taking a direct dependency on `url`. Closes cloudflare#380.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Url::parsereturnsResult<Url, ParseError>andErroralready has aFrom<url::ParseError>impl, but onlyUrlis re-exported. Naming the error type means taking a direct dependency onurl.Re-exports it alongside
Url(pub use url::{ParseError, Url};), with a trybuildpasstest next to thestart-handler.rsone from #974.Adding
ParseErrorat the root can conflict underuse worker::*ifchrono'sParseErroris also in scope via*, though I didn't find a public crate doing that and an explicit import clears it. Given #890, I can re-export theurlmodule forworker::url::ParseErrorinstead if you'd prefer.Closes #380.