feat(chart): add ChoroplethMap by AnmolSaini16 · Pull Request #610 · cloudflare/kumo

AnmolSaini16 · 2026-06-29T16:28:44Z

Adds ChoroplethMap, a GeoJSON region choropleth chart component with Kumo light/dark map colors, tooltip formatting, optional legend, hover/click callbacks, roam controls, docs, demos, exports, and a changeset.

Reviews

bonk has reviewed the change
automated review not possible because: GitHub review automation is not available from this environment

Tests

Tests included/updated
Automated tests not possible - manual testing has been completed as follows: ran pnpm --filter @cloudflare/kumo-docs-astro typecheck with 0 errors; existing warnings/hints remain unrelated
Additional testing not necessary because:

AnmolSaini16 · 2026-06-29T16:32:33Z

/bonk please review

stritt · 2026-06-30T17:10:19Z

/bonk please review

pkg-pr-new · 2026-06-30T17:12:37Z

npm i https://pkg.pr.new/@cloudflare/kumo@610

commit: 595cbdf

github-actions · 2026-06-30T17:13:47Z

Docs Preview

View docs preview

Commit: 595cbdf

ask-bonk

Thanks for the PR! The ChoroplethMap implementation is well-structured — clean viewport preservation, consistent event handling with BubbleMap, and nice Kumo color integration.

A few things to address before merging:

BubbleMap default change is undocumented. Switching the default from → changes the default interaction behavior for existing consumers. If this is intentional it should be called out in the changeset.
Missing ChoroplethMap PropsTable in docs. The API Reference section should include a PropsTable for the new component too.
Test page consistency. The ChoroplethMap test section is missing a descriptive paragraph like the other sections have.

See inline comments for details.

ask-bonk · 2026-06-30T17:16:41Z

  zoom?: number;
-  /** Enable drag-to-pan and scroll-to-zoom. Default: `true`. */
+  /** Enable drag-to-pan and scroll-to-zoom. Default: `false`. */
  roam?: boolean;


The BubbleMap default changed from to but the changeset () only mentions the viewport-preservation fix. Existing consumers who omit the prop will lose drag-to-pan/scroll-to-zoom on upgrade.

Please either revert the default to (the fix already solves the reset issue) or update the changeset to document this breaking interaction change.

ask-bonk · 2026-06-30T17:16:41Z

  <ComponentSection>
    <Heading level={2}>API Reference</Heading>
+    <Heading level={3} class="mb-2 mt-4 text-lg">BubbleMap</Heading>
    <PropsTable component="BubbleMap" />


Please add a PropsTable for as well.

ask-bonk · 2026-06-30T17:16:41Z

+
+    <section class="space-y-4">
+      <div>
+        <h2 class="text-xl font-semibold text-kumo-default">ChoroplethMapBasicDemo</h2>


For consistency with the other test sections, consider adding a description paragraph.

github-actions · 2026-06-30T17:17:11Z

Visual Regression Report — 26 changed, 15 unchanged

26 screenshot(s) with visual changes:

Button / Variant: Primary

468 px (0.46%) changed

Before	After	Diff

Button / Sizes

1,091 px (1.07%) changed

Before	After	Diff

Button / Icon Only

268 px (0.26%) changed

Before	After	Diff

Button / Loading State

14 px (0.01%) changed

Before	After	Diff

Button / Link as Button

1,083 px (1.07%) changed

Before	After	Diff

Dialog / Dialog With Actions

363 px (0.36%) changed

Before	After	Diff

Dialog / Dialog Basic

404 px (0.4%) changed

Before	After	Diff

Dialog / Dialog Sizes

2,303 px (2.27%) changed

Before	After	Diff

Dialog / Dialog Alert

1,324 px (1.3%) changed

Before	After	Diff

Dialog / Custom Max Width

954 px (0.94%) changed

Before	After	Diff

Dialog / Dialog With Select

480 px (0.47%) changed

Before	After	Diff

Dialog / Dialog With Dropdown

500 px (0.49%) changed

Before	After	Diff

Dialog (Open)

0 px (0%) changed

Before	After	Diff

Select / Select Basic

859 px (0.85%) changed

Before	After	Diff

Select / Select Sizes

3,195 px (1.72%) changed

Before	After	Diff

Select / Select Without Label

723 px (0.71%) changed

Before	After	Diff

Select / Select With Error

1,730 px (1.46%) changed

Before	After	Diff

Select / Select Placeholder

1,234 px (1.22%) changed

Before	After	Diff

Select / Select With Tooltip

1,062 px (1.05%) changed

Before	After	Diff

Select / Select Custom Rendering

973 px (0.96%) changed

Before	After	Diff

Select / Select Loading

0 px (0%) changed

Before	After	Diff

Select / Select Disabled Items

793 px (0.78%) changed

Before	After	Diff

Select / Select Grouped

813 px (0.8%) changed

Before	After	Diff

Select / Select Grouped With Disabled

1,478 px (1.46%) changed

Before	After	Diff

Select / Select Long List

2,196 px (1.85%) changed

Before	After	Diff

Select (Open)

0 px (0%) changed

Before	After	Diff

15 screenshot(s) unchanged

Button / Basic
Button / Variant: Secondary
Button / Variant: Ghost
Button / Variant: Destructive
Button / Variant: Outline
Button / Variant: Secondary Destructive
Button / With Icon
Button / Disabled State
Button / Title
Dialog / Dialog Confirmation
Dialog / Dialog With Combobox
Select / Select With Description
Select / Select Multiple
Select / Select Complex
Select / Select Disabled Options

Generated by Kumo Visual Regression

ask-bonk · 2026-06-30T17:18:14Z

Follow-up: my earlier review comments lost some backticks due to escaping issues. Here is the same feedback with proper formatting:

BubbleMap roam default change is undocumented
In Maps.tsx, the BubbleMap roam default changed from true to false. The tame-maps-walk.md changeset only mentions the viewport-preservation fix, but existing consumers who omit the roam prop will lose drag-to-pan/scroll-to-zoom on upgrade. Please either revert the default to true (the appliedGeoRef fix already solves the reset issue) or update the changeset to document this breaking interaction change.
Missing ChoroplethMap PropsTable in docs
In maps.astro, the API Reference section should include a PropsTable for the new component too. Add this after the BubbleMap PropsTable:
```
<Heading level={3} class="mb-2 mt-4 text-lg">ChoroplethMap</Heading>
<PropsTable component="ChoroplethMap" />
```
Test page consistency
In map.astro, the ChoroplethMap test section is missing a descriptive paragraph like the other sections have. Consider adding something like:
```
<p class="text-kumo-subtle">
  Choropleth map shading regions by value with continuous colour scaling.
</p>
```

Otherwise the implementation looks solid. Nice work!

ask-bonk · 2026-06-30T17:18:24Z

Review submitted on PR #610.

Summary of feedback:

BubbleMap roam default change is undocumented — the default switched from true to false but the changeset only mentions the viewport-preservation fix. Existing consumers who don’t set roam explicitly will lose pan/zoom on upgrade. The author should either revert the default or update the changeset.
Missing PropsTable for ChoroplethMap in the docs page’s API Reference section.
Test page consistency — the ChoroplethMap test section lacks a descriptive paragraph like the other sections.

The batch review was posted successfully (with inline comments on the relevant lines), and a follow-up top-level comment clarifies the properly formatted feedback.

github run

AnmolSaini16 added 2 commits June 26, 2026 17:15

fix(chart): preserve BubbleMap view on data refresh

4db6584

feat(chart): add ChoroplethMap

595cbdf

ask-bonk Bot reviewed Jun 30, 2026

View reviewed changes

Uh oh!

Conversation

AnmolSaini16 commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AnmolSaini16 commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stritt commented Jun 30, 2026

Uh oh!

pkg-pr-new Bot commented Jun 30, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Docs Preview

Uh oh!

ask-bonk Bot left a comment

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 30, 2026

Button / Variant: Primary

Button / Sizes

Button / Icon Only

Button / Loading State

Button / Link as Button

Dialog / Dialog With Actions

Dialog / Dialog Basic

Dialog / Dialog Sizes

Dialog / Dialog Alert

Dialog / Custom Max Width

Dialog / Dialog With Select

Dialog / Dialog With Dropdown

Dialog (Open)

Select / Select Basic

Select / Select Sizes

Select / Select Without Label

Select / Select With Error

Select / Select Placeholder

Select / Select With Tooltip

Select / Select Custom Rendering

Select / Select Loading

Select / Select Disabled Items

Select / Select Grouped

Select / Select Grouped With Disabled

Select / Select Long List

Select (Open)

Uh oh!

ask-bonk Bot commented Jun 30, 2026

Uh oh!

ask-bonk Bot commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AnmolSaini16 commented Jun 29, 2026 •

edited

Loading

AnmolSaini16 commented Jun 29, 2026 •

edited

Loading