feat(flow): add vertical orientation#608
Open
mattrothenberg wants to merge 2 commits into
Open
Conversation
Wires up the previously no-op `orientation="vertical"` prop on Flow. The connector path routing and parallel-branch geometry already handled the vertical axis; this fills the remaining gap in FlowNodeList's top-level connector computation and makes the node list lay out top-to-bottom, with `align` controlling cross-axis (horizontal) alignment. Adds vertical demos, docs, and tests.
41ac04f to
a20bbc4
Compare
commit: |
Contributor
Docs PreviewCommit: |
Collaborator
Author
|
/bonk please review and approve |
Contributor
|
bonk review: approved Clean, minimal change that wires up the already-existing vertical connector/branch logic. I verified all six changed files:
No blockers. LGTM. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





































































Adds support for
orientation="vertical"on theFlowcomponent, laying nodes out top-to-bottom instead of the default left-to-right.The connector path routing and parallel-branch geometry already accounted for the vertical axis; this is the small remaining wiring in
FlowNodeList's top-level connector computation and node-list layout so the prop is fully functional. Thealignprop now controls cross-axis alignment in both orientations (vertical alignment when horizontal, horizontal alignment when vertical).Also adds vertical demos to the docs, a Vertical Orientation example +
orientationprops-table entry on the component page, and unit tests.