Extract file and line at point into functions#62
Open
markgdawson wants to merge 14 commits into
Open
Conversation
Resolve changed files from git with absolute paths, to pass to file tracing function.
Member
|
Seems to me this is more or less the same branch as the one for the Magit integration. |
Member
|
Thanks @markgdawson, and sorry for the long silence here. The codebase has moved on quite a bit since 2021 (CI, deps, the nREPL client got reworked), so this would need a rebase. The file/line extraction is reasonable on its own - are you still interested in reviving it? Otherwise I'll close it as stale in a couple of weeks, no hard feelings, and a fresh PR is always welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've extracted the functions to determine file name and line number into functions, for use in user-defined functions.