Feat: Enable editing collaborating organizations#1116
Conversation
JoshKornfeld
requested review from
ddhanesha and
positiveimpact
as code owners
piperchester
left a comment
piperchester
left a comment
There was a problem hiding this comment.
Nice work @JoshKornfeld! Leaving some flyby comments.
| @@ -72,15 +73,16 @@ export default function MiniOrganizationPreview({ | |||
| size={size} | |||
| onDelete={onDelete} | |||
| doNotShowName={doNotShowName} | |||
There was a problem hiding this comment.
Out of scope for this PR, but do you know why we have a mix of the negative like doNotShow and positive like show prefixes? I think from a component API perspective we should align on one pattern.
There was a problem hiding this comment.
I had defined doNotShowName as a negative because there was only 1 instance of MiniOrganizationPreview where I didn't want the name to be shown and I didn't want to modify the props of the other instances everywhere else.
…ct/climateconnect into fix/edit-collaborating-orgs
ddhanesha
left a comment
ddhanesha
left a comment
There was a problem hiding this comment.
The feature requirements are not clearly identified in the original #1112 . @JoshKornfeld I would recommend that you consult with @positiveimpact and @tobiasrehm about requirements. I do not think I can approve this PR without clear requirements.
|
|
||
| return ( | ||
| <> | ||
| {/* TODO: Currently allows any org to be added, maybe needs some verification on selected orgs part*/} |
There was a problem hiding this comment.
I think this is very important feature to have. I don't think we should allow any organization to be added. Lets make sure that feature requirements are clarified before we move forward merging this PR.
There was a problem hiding this comment.
We should maybe look to create an issue for this as its own PR, with also making this check for project creation?
|
@JoshKornfeld please resolve merge conflicts |
3 participants
Description
Closes #1112
PR includes formatting. Specific file changes will be mentioned here.
Backend: Modified editing API to include collaborating orgs.
project_views.pyFrontend:
project_texts.jsby adding some extra stringsEditCollaboratingOrganizations.js. This component utilizes the AutoCompleteSearchBar to add any existing organization as a collaborator and MiniOrganizationPreviews to display the existing collaborating organization underneath.EditProjectContent.jsalongside supporting functionality responsible for adding/removing orgs.MiniOrganizationPreviews.jsprops modified to show a gray border around the mini org previews.ProjectMetaData.jsmakes use of the new prop to show a gray border conditionally.Post.jsNew Interface for editing collaborating orgs as follows:
Test plan
Before landing
yarn lintpasses (frontend)yarn formatpasses (frontend)make formatpasses (backend)