Align with hs2p 4.2.0: drop TilingConfig.tissue_threshold reads (#182)#183
Merged
Conversation
hs2p 4.2.0 (clemsgrs/hs2p#158) collapses the derived TilingConfig.tissue_threshold scalar into the resolved min_coverage map, the single source of truth (min_coverage["tissue"] is the tissue threshold). slide2vec's runtime is already masks-only and never reads the scalar; only the test suite and a stale comment referenced it. - pyproject.toml: bump hs2p pin >=4.1.2 -> >=4.2.0 - tests: assert tiling_cfg.min_coverage["tissue"] instead of the removed tiling_cfg.tissue_threshold - runtime/tiling.py: reword the resolver comment for the field-removed world Full suite green against hs2p 4.2.0 (359 passed, 15 skipped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182.
hs2p 4.2.0 (clemsgrs/hs2p#158) collapses the derived
TilingConfig.tissue_thresholdscalar into the resolvedmin_coveragemap — the single source of truth, wheremin_coverage["tissue"]is the tissue threshold.slide2vec's runtime is unaffected: it never constructs a
TilingConfig, already drops the standalone scalar (min_coverage.tissueis the source of truth), andbuild_hs2p_configs(runtime/tiling.py) delegates derivation to hs2p'sresolve_tiling_config. No shipping code reads.tissue_thresholdoff the result — only the test suite and one stale comment did.Changes
pyproject.toml— bump pinhs2p[...]>=4.1.2→>=4.2.0(both dependency blocks)tests/test_regression_core.py— asserttiling_cfg.min_coverage["tissue"](≈ 0.37) instead of the removedtiling_cfg.tissue_thresholdtests/test_regression_inference.py— same migration (≈ 0.1); comment reworded "derived" → "resolved"slide2vec/runtime/tiling.py— reword the resolver comment for the field-removed world (min_coverage["tissue"]is the threshold)Verification
Upgraded the local env to hs2p 4.2.0 and ran the full suite: 359 passed, 15 skipped.
Release ordering
Per #182, release after hs2p 4.2.0 (done) and before soma (clemsgrs/soma#97).