Skip to content

Fix DistributedzkSNARKTest class #1

Description

@AntoineRondelet

For now, the DistributedzkSNARKTest class runs 3 tests. One for a "fake" pairing group and one for BN254a, BN254b.
After bumping all plugins/dependency/JDK/Compiler versions the tests fail because of this test class (DistributedzkSNARKTest).
In fact, the execution of DistributedBN254bProofSystemTest throws a NullPtr exception, which after a close look to the code doesn't immediately make sense. After commenting the 2 first test cases (namely DistributedBN254aProofSystemTest and DistributedFakeProofSystemTest) the test pass nicely and the NullPtr isn't thrown. This is confirmed by the fact that when executing each function annotated with @Test in the class independently in an IDE, all functions pass. As such, it seems that the issue come from surefire. That being said, I can't pinpoint where things go wrong, it seems that the this.G1Parameters (where this is the g1Factory for the BN254b pairing group) become null as some point in the execution of the test when all tests of the DistributedzkSNARKTest class are executed. I can't think about any place where this object is modified...
This needs further investigation - and will probably translate into opening a ticket to surefire to see if this can come from there.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't workingtesting

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions