Skip to content

update ids in svg style attributes as well as tags: https://github.co… - #52

Merged
ronaldtse merged 4 commits into
mainfrom
fix/style-attribute-disambig-id-css
Jan 20, 2026
Merged

update ids in svg style attributes as well as tags: https://github.co…#52
ronaldtse merged 4 commits into
mainfrom
fix/style-attribute-disambig-id-css

Conversation

@opoudjis

Copy link
Copy Markdown
Contributor

@opoudjis opoudjis self-assigned this Jan 17, 2026
@opoudjis

opoudjis commented Jan 17, 2026

Copy link
Copy Markdown
Contributor Author

I am having to address the fact that this abandonware's generated PS files are obsolete, and failing when uploaded to GHA, because the PS files need to be updated with updates to Cairo.

opoudjis added a commit that referenced this pull request Jan 17, 2026
@opoudjis

opoudjis commented Jan 17, 2026

Copy link
Copy Markdown
Contributor Author

The nightmare continues. The current of Cairo 1.18.2 bundled with Inkspace on GHA is different from the Cairo 1.18.4 bundled with Inkspace on my Mac.

This test is idiotic, and was a hack by Morozov, which will be dispensed with with great anger and brusqueness. Since we cannot guarantee the version of Cairo being run between environments, the solution is not to demand a match in the file content: the point of the test is merely to confirm that conversion is happening at all. I am loosening the tests.

A reminder that maintaining Vectory is not my goddamn job, and I will not be held up because of it.

@opoudjis

Copy link
Copy Markdown
Contributor Author

I'm going to loosen the two tests currently failing because of Cairo mismatches to just detect that the file generated is of the desired format.

opoudjis added a commit that referenced this pull request Jan 17, 2026
opoudjis added a commit that referenced this pull request Jan 17, 2026
…anorma#521

- Update IDs in inline style attributes (not just <style> tags)
- Update url(#id) references when suffixing attributes in SVG
- Share SVG style manipulation code with Metanorma gem
@ronaldtse
ronaldtse force-pushed the fix/style-attribute-disambig-id-css branch from 02804be to 843caa0 Compare January 20, 2026 04:14
@ronaldtse
ronaldtse merged commit dc31887 into main Jan 20, 2026
11 checks passed
@ronaldtse
ronaldtse deleted the fix/style-attribute-disambig-id-css branch January 20, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants