feat: parse full ExtTextOutW/ExtTextOutA wire layout - #4
Merged
Conversation
Previously these records stubbed the trailing fields as 'rest :body' which preserved bytes for round-trip but made the text-layout fields inaccessible to consumers. Now declares the full layout: - iGraphicsMode, exScale, eyScale - ref.WmfRect16 (4 int16 — reference rectangle) - nChars, offString - fOptions (ExtTextOutOptions flags) - ref.WmfRect16_2 (user rectangle) - offDx (offset to character-spacing array) - trailing bytes (string + Dx array) Round-trip verified: 186/186 EMF fixtures + 21 EMF-EA + simple all still byte-identical. Enables emfsvg to render text content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to emfsvg PR #2. The previous stub used
rest :bodywhich preserved bytes for round-trip but made text-layout fields inaccessible.This declares the full MS-EMF 2.3.8 layout so emfsvg can render text. Round-trip verified: 208/208 fixtures byte-identical.