feat: add now playing text overlay - #1803
Open
abaltuta wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at #1766 and this was a use case I honestly wanted.
Here is my attempt to add this in a very naive way.
Note: I developed this on Windows so some fixes are probably too Windows specific and I don't have access to my other machines on Linux or Mac to test it out there, sorry about that.
It adds the current file information as well as the "coming up next", useful for music videos. All 3 overlays are configurable in terms of time, not anything else. ffmpeg syntax was awful to fix with no prior experience.
It displays the file name or file information, if possible, either from the library or from
ffprobe.I've tried my best to remain faithful to the current architecture, add tests and debug messages when appropriate. I've also added documentation for this.
I know this doesn't use Skia Canvas, but this was simple enough to bang out in an evening and it's a patch I'll probably run myself if this doesn't get merged (albeit in a simpler form to have fewer conflicts to manage 😆 ).
Note: I hope this goes without saying that you can make any changes to this PR as you see fit.