Add support for Rust lang - #83
Open
dauom wants to merge 1 commit into
Open
Conversation
dauom
marked this pull request as draft
June 7, 2021 23:57
dauom
marked this pull request as ready for review
June 7, 2021 23:57
chermehdi
requested changes
Jun 13, 2021
chermehdi
left a comment
chermehdi
left a comment
Owner
There was a problem hiding this comment.
Can you also bump the fix version number in the egor config.
| } | ||
| // should not get here. | ||
| return "" | ||
| panic(fmt.Sprintf("unsupported language: %s", lang)) |
Owner
There was a problem hiding this comment.
don't panic within a function, the caller is supposed to handle the error (by panicking or doing something else).
Owner
|
Overall the PR looks good, still a couple of small changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.