Add release helper script. - #175
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a release script that validates version arguments, checks out backend and frontend revisions, exports resolved versions, and updates Docker Compose image tags, including an optional Motiva image. ChangesRelease helper
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contrib/release.sh`:
- Around line 10-25: Harden the option parsing loop in contrib/release.sh: for
each --backend, --frontend, and --motiva case, validate that a following
argument exists before reading it or executing shift 2, and reject missing
values with an error. Update the final backend and frontend validation to
require the release-tag format vX.Y.Z rather than merely non-empty values, while
preserving the existing unknown-option handling.
- Around line 1-4: Update the contrib/release.sh shell setup by removing set -o
pipefail while retaining POSIX /bin/sh compatibility, and quote the BACKEND and
FRONTEND references in the git checkout commands to prevent word splitting.
- Around line 28-30: Quote the BACKEND and FRONTEND expansions in the git
checkout commands within the release script to ensure each revision is passed as
a single argument, while preserving the existing repository and command flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3b5e3967-0c3c-486a-99ba-ee4cad1aafca
📒 Files selected for processing (1)
contrib/release.sh
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: Analyze (actions)
🧰 Additional context used
🪛 Shellcheck (0.11.0)
contrib/release.sh
[warning] 4-4: In POSIX sh, set option pipefail is undefined.
(SC3040)
[info] 28-28: Double quote to prevent globbing and word splitting.
(SC2086)
[info] 30-30: Double quote to prevent globbing and word splitting.
(SC2086)
🔇 Additional comments (1)
contrib/release.sh (1)
6-8: LGTM!Also applies to: 27-27, 32-40
7c85b72 to
25b6e37
Compare
Summary by CodeRabbit